Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update google.golang.org/api to v0.65.0 #9608

Closed
wants to merge 1 commit into from
Closed

Update google.golang.org/api to v0.65.0 #9608

wants to merge 1 commit into from

Conversation

espadolini
Copy link
Contributor

@espadolini espadolini commented Dec 31, 2021 •
edited
Loading

Necessary for #8122.

@espadolini espadolini force-pushed the espadolini/update-etcd branch from 03b4664 to c69e0c4 Compare January 3, 2022 13:00
@espadolini espadolini force-pushed the espadolini/update-googleapi branch from 6ea6fbc to e496dbb Compare January 3, 2022 13:04
@espadolini espadolini force-pushed the espadolini/update-etcd branch from c69e0c4 to 99f0810 Compare January 4, 2022 19:12
@espadolini espadolini force-pushed the espadolini/update-googleapi branch from e496dbb to 4110ec9 Compare January 4, 2022 19:12
r0mant
r0mant approved these changes Jan 5, 2022
View reviewed changes
Copy link
Collaborator

@r0mant r0mant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@espadolini LGTM, let's merge after @zmb3's change that removes vendor directory lands.

@espadolini espadolini force-pushed the espadolini/update-etcd branch 3 times, most recently from 951bcb6 to dc4cfba Compare January 7, 2022 17:19
@espadolini
Copy link
Contributor Author

Now that we don't have the vendor directory anymore, it might be worth it to just update the required dependencies directly in the actual feature PR (#9697). What do you think @r0mant?

@espadolini espadolini force-pushed the espadolini/update-etcd branch from dc4cfba to f40dda4 Compare January 10, 2022 09:53
Base automatically changed from espadolini/update-etcd to master January 10, 2022 18:44
@espadolini espadolini force-pushed the espadolini/update-googleapi branch from 4110ec9 to 95362ee Compare January 11, 2022 17:03
@espadolini espadolini changed the title Update google.golang.org/api to v0.63.0 Update google.golang.org/api to v0.64.0 Jan 11, 2022
@espadolini espadolini force-pushed the espadolini/update-googleapi branch from 95362ee to b9d723c Compare January 12, 2022 10:05
@espadolini espadolini changed the title Update google.golang.org/api to v0.64.0 Update google.golang.org/api to v0.65.0 Jan 12, 2022
@espadolini
Copy link
Contributor Author

Closing in favour of just inlining the upgrade as part of #9697, as per @russjones.

@espadolini espadolini closed this Jan 13, 2022
@espadolini espadolini deleted the espadolini/update-googleapi branch January 13, 2022 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r0mant r0mant r0mant approved these changes

@ibeckermayer ibeckermayer ibeckermayer approved these changes

@zmb3 zmb3 Awaiting requested review from zmb3

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@espadolini @r0mant @ibeckermayer