use aws sdk withcontext variants where possible #8355
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosstimothy
requested review from
klizhentas,
r0mant and
russjones
as code owners
andrejtokarcik
approved these changes
Sep 23, 2021
rosstimothy
force-pushed
the
tross/aws-withcontext
branch
from
6f7404a to
aef358c
Compare
|
Note that with #8292 now merged there might be some additional calls that need to be converted to |
rosstimothy
force-pushed
the
tross/aws-withcontext
branch
from
aef358c to
acb91be
Compare
fspmarshall
approved these changes
Oct 4, 2021
rosstimothy
force-pushed
the
tross/aws-withcontext
branch
2 times, most recently
from
b661bee to
254d95a
Compare
rosstimothy
force-pushed
the
tross/aws-withcontext
branch
from
254d95a to
543d3ee
Compare
rosstimothy
added a commit
that referenced
this pull request
Oct 6, 2021
rosstimothy
added a commit
that referenced
this pull request
Oct 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure that dynamo and s3 requests are using the provided context so that timeouts and cancellation are respected.