Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 6.2] Add regexp.replace support in role templates #7250

Merged
merged 2 commits into from
Jun 10, 2021
Merged

[Backport 6.2] Add regexp.replace support in role templates #7250

merged 2 commits into from
Jun 10, 2021

Conversation

nklaassen
Copy link
Contributor

Original PR #7152

inertial-frame
inertial-frame approved these changes Jun 10, 2021
View reviewed changes
Copy link
Contributor

@inertial-frame inertial-frame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs signoff - thanks! Super helpful updates!

@nklaassen nklaassen enabled auto-merge (squash) June 10, 2021 04:09
@nklaassen nklaassen disabled auto-merge June 10, 2021 16:12
@nklaassen nklaassen merged commit a96e20e into branch/v6.2 Jun 10, 2021
@nklaassen nklaassen deleted the nklaassen/v6.2/regexp-replace branch June 10, 2021 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r0mant r0mant r0mant approved these changes

@inertial-frame inertial-frame inertial-frame approved these changes

@klizhentas klizhentas Awaiting requested review from klizhentas

@russjones russjones Awaiting requested review from russjones

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nklaassen @r0mant @inertial-frame