Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v6.1] access requests from workflows #6620

Merged
merged 4 commits into from
Apr 27, 2021
Merged

Conversation

inertial-frame
Copy link
Contributor

This PR addresses updates to v6.1 docs for #6588:

  1. Access Workflows -> Access Requests or Access Request workflows where appropriate
  2. Update config.json to update TOC names
  3. Update admonitions to tips and state support for this feature in both Open Source and Enterprise versions now

Thanks!

@inertial-frame inertial-frame self-assigned this Apr 27, 2021
@inertial-frame inertial-frame changed the title [v6.1] Adam/docs/61rename [v6.1] access requests from workflows Apr 27, 2021
Copy link
Contributor

@klizhentas klizhentas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with a couple of tweaks.

@@ -120,8 +120,8 @@ cryptographic module (BoringCrypto) and fails to start if it was not.

See our [FedRAMP for SSH and Kubernetes](ssh-kubernetes-fedramp.mdx) guide for more infromation.

## Approval Workflows
## Approval Requests
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's rename Approval Workflows to Access Requests too, so there is only one term remaining


Read the [Approval Workflows Guide for more information](workflow/index.mdx)
Read the [Approval Requests Guide for more information](workflow/index.mdx)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

@klizhentas klizhentas merged commit a6a0840 into branch/v6.1 Apr 27, 2021
@klizhentas klizhentas deleted the adam/docs/61rename branch April 27, 2021 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants