Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[6.1] Backport - Close leaky directClient (#6297) #6298

Merged
merged 2 commits into from
Apr 2, 2021
Merged

[6.1] Backport - Close leaky directClient (#6297) #6298

merged 2 commits into from
Apr 2, 2021

Conversation

Joerger
Copy link
Contributor

@Joerger Joerger commented Apr 2, 2021 •
edited
Loading

@Joerger Joerger requested a review from awly April 2, 2021 20:09
r0mant
r0mant approved these changes Apr 2, 2021
View reviewed changes
Copy link
Collaborator

@r0mant r0mant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as in #6297.

@Joerger Joerger force-pushed the joerger/fix/close-failed-direct-client-v6 branch from 88ad302 to 5f78834 Compare April 2, 2021 21:18
@Joerger Joerger enabled auto-merge (squash) April 2, 2021 21:19
@Joerger Joerger merged commit 7d92243 into branch/v6 Apr 2, 2021
@Joerger Joerger deleted the joerger/fix/close-failed-direct-client-v6 branch April 2, 2021 21:41
@webvictim webvictim mentioned this pull request May 5, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@r0mant r0mant r0mant approved these changes

@awly awly awly approved these changes

@klizhentas klizhentas Awaiting requested review from klizhentas klizhentas is a code owner

@russjones russjones Awaiting requested review from russjones russjones is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Joerger @r0mant @awly