mfa: don't check MFA for teleport services in UpsertKubeService #6129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r0mant
approved these changes
Mar 24, 2021
| @@ -2625,8 +2625,14 @@ func (a *ServerWithRoles) UpsertKubeService(ctx context.Context, s services.Serv | |||
| if err != nil { | |||
| return trace.Wrap(err) | |||
| } | |||
| _, isService := a.context.Checker.(BuiltinRoleSet) | |||
There was a problem hiding this comment.
Can only kube service do this? There's hasBuiltinRole if you wanted to check for only kube service here.
There was a problem hiding this comment.
Kube or Proxy.
We already have this enforced in e.g. https://github.com/gravitational/teleport/blob/master/lib/auth/permissions.go#L547, I'd rather not duplicate that authz logic here.
awly
pushed a commit
that referenced
this pull request
Mar 25, 2021
awly
pushed a commit
that referenced
this pull request
Mar 29, 2021
awly
pushed a commit
that referenced
this pull request
Mar 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.