-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
u2f: add optional attestation cert validation #6057
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcfe740
to
01ea6fd
Compare
Joerger
approved these changes
Mar 20, 2021
r0mant
approved these changes
Mar 21, 2021
359f223
to
8d16250
Compare
By specifying `device_attestation_cas` in `teleport.yaml`, admins can restrict U2F device manufacturers. For example, specifying the yubico attestation CA (https://developers.yubico.com/U2F/yubico-u2f-ca-certs.txt), you can restrict users to only yubikeys. Example error when using the yubico CA and trying to register a Google Titan key: ``` $ tsh mfa add --type u2f --name test && tsh mfa rm test Tap any *registered* security key Tap your *new* security key ERROR: rpc error: code = InvalidArgument desc = U2F device attestation certificate is signed by "CN=Security Key,O=Google", but this cluster only accepts certificates from ["CN=Yubico U2F Root CA Serial 457200631"]; make sure you're using a U2F device from a trusted manufacturer ```
8d16250
to
ed368c1
Compare
awly
pushed a commit
that referenced
this pull request
Mar 25, 2021
By specifying `device_attestation_cas` in `teleport.yaml`, admins can restrict U2F device manufacturers. For example, specifying the yubico attestation CA (https://developers.yubico.com/U2F/yubico-u2f-ca-certs.txt), you can restrict users to only yubikeys. Example error when using the yubico CA and trying to register a Google Titan key: ``` $ tsh mfa add --type u2f --name test && tsh mfa rm test Tap any *registered* security key Tap your *new* security key ERROR: rpc error: code = InvalidArgument desc = U2F device attestation certificate is signed by "CN=Security Key,O=Google", but this cluster only accepts certificates from ["CN=Yubico U2F Root CA Serial 457200631"]; make sure you're using a U2F device from a trusted manufacturer ```
awly
pushed a commit
that referenced
this pull request
Mar 29, 2021
By specifying `device_attestation_cas` in `teleport.yaml`, admins can restrict U2F device manufacturers. For example, specifying the yubico attestation CA (https://developers.yubico.com/U2F/yubico-u2f-ca-certs.txt), you can restrict users to only yubikeys. Example error when using the yubico CA and trying to register a Google Titan key: ``` $ tsh mfa add --type u2f --name test && tsh mfa rm test Tap any *registered* security key Tap your *new* security key ERROR: rpc error: code = InvalidArgument desc = U2F device attestation certificate is signed by "CN=Security Key,O=Google", but this cluster only accepts certificates from ["CN=Yubico U2F Root CA Serial 457200631"]; make sure you're using a U2F device from a trusted manufacturer ```
awly
pushed a commit
that referenced
this pull request
Mar 29, 2021
By specifying `device_attestation_cas` in `teleport.yaml`, admins can restrict U2F device manufacturers. For example, specifying the yubico attestation CA (https://developers.yubico.com/U2F/yubico-u2f-ca-certs.txt), you can restrict users to only yubikeys. Example error when using the yubico CA and trying to register a Google Titan key: ``` $ tsh mfa add --type u2f --name test && tsh mfa rm test Tap any *registered* security key Tap your *new* security key ERROR: rpc error: code = InvalidArgument desc = U2F device attestation certificate is signed by "CN=Security Key,O=Google", but this cluster only accepts certificates from ["CN=Yubico U2F Root CA Serial 457200631"]; make sure you're using a U2F device from a trusted manufacturer ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By specifying
device_attestation_cas
inteleport.yaml
, admins canrestrict U2F device manufacturers. For example, specifying the yubico
attestation CA
(https://developers.yubico.com/U2F/yubico-u2f-ca-certs.txt), you can
restrict users to only yubikeys.
Example error when using the yubico CA and trying to register a Google
Titan key:
Also cleaned up legacy U2F config code which was unused.
Updates #5878