Define cloud billing event types and codes #6037
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-kovoy
reviewed
Mar 17, 2021
lib/events/codes.go
Outdated
| @@ -294,6 +294,14 @@ const ( | |||
| MFADeviceAddEventCode = "T1006I" | |||
| // MFADeviceDeleteEventCode is an event code for users deleting MFA devices. | |||
| MFADeviceDeleteEventCode = "T1007I" | |||
| // BillingCardCreateCode is emitted when a user creates a new credit card. | |||
| BillingCardCreateCode = "T1008I" | |||
There was a problem hiding this comment.
If you look at numbers, the T10xxx is used for user login events. The billing deserve own group.
Lets use TBL prefix for that:
TBL01I
TBL02I
kimlisa
force-pushed
the
lisa/define-billing-events
branch
from
251dae6 to
b51d453
Compare
alex-kovoy
reviewed
Mar 18, 2021
api/types/events/events.proto
Outdated
| @@ -1263,6 +1297,9 @@ message OneOf { | |||
| events.SessionUpload SessionUpload = 43; | |||
| events.MFADeviceAdd MFADeviceAdd = 44; | |||
| events.MFADeviceDelete MFADeviceDelete = 45; | |||
| events.BillingAccountUpdate BillingAccountUpdate = 46; | |||
There was a problem hiding this comment.
BillingAcountUpdate -> BillingInformationUpdate
alex-kovoy
approved these changes
Mar 18, 2021
lib/events/api.go
Outdated
| // BillingCardUpdateEvent is emitted when a user updates an existing credit card. | ||
| BillingCardUpdateEvent = "billing.update_card" | ||
| // BillingAccountUpdateEvent is emitted when a user updates their billing account. | ||
| BillingAccountUpdateEvent = "billing.update_account" |
There was a problem hiding this comment.
BillingAccountUpdate -> BillingInformationUpdate
kimlisa
force-pushed
the
lisa/define-billing-events
branch
from
0d178fe to
1cfe787
Compare
kimlisa
force-pushed
the
lisa/define-billing-events
branch
2 times, most recently
from
63b02f5 to
0ac06d9
Compare
klizhentas
approved these changes
Mar 23, 2021
- Exported auth.clientUsername so it can be used in enterprise
- Stayed with convention and created seperate create(upsert) and delete event objects in proto file - Renamed event code numbers
kimlisa
force-pushed
the
lisa/define-billing-events
branch
from
0ac06d9 to
e192d27
Compare
kimlisa
added a commit
that referenced
this pull request
Mar 29, 2021
* Exported auth.clientImpersonator and auth.clientUsername for use in e
kimlisa
added a commit
that referenced
this pull request
Mar 29, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of https://github.com/gravitational/cloud/issues/442
Description