Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow file argument with tsh play #5984

Merged
merged 22 commits into from
Mar 25, 2021
Merged

Allow file argument with tsh play #5984

merged 22 commits into from
Mar 25, 2021

Conversation

quinqu
Copy link
Contributor

@quinqu quinqu commented Mar 12, 2021 •
edited
Loading

Purpose

From 4.4+, Teleport no longer supported taking in a tar file as an argument for tsh play so it is now reintroduced because many users wanted this feature back. Users also don't need auth servers to run when wanting to use tsh play with file arg.

Resolves #4931
Resolves #1580

Implementation

  • Extract and write the files for playback and save them to the OS's temp directory
  • Read the file contents into existing player
  • Delete files after finished playing

@quinqu quinqu marked this pull request as ready for review March 15, 2021 23:08
a-palchikov
a-palchikov reviewed Mar 16, 2021
View reviewed changes
a-palchikov
a-palchikov approved these changes Mar 17, 2021
View reviewed changes
@quinqu quinqu force-pushed the jane/tshPlayFileArg branch from d13c12e to 28538f5 Compare March 17, 2021 15:52
a-palchikov
a-palchikov reviewed Mar 17, 2021
View reviewed changes
@quinqu quinqu requested a review from xacrimon March 17, 2021 23:18
@russjones
Copy link
Contributor

@fspmarshall Can you review?

@quinqu quinqu force-pushed the jane/tshPlayFileArg branch from 922e875 to 26ad56d Compare March 18, 2021 19:17
a-palchikov
a-palchikov reviewed Mar 19, 2021
View reviewed changes
a-palchikov
a-palchikov approved these changes Mar 24, 2021
View reviewed changes
russjones
russjones approved these changes Mar 25, 2021
View reviewed changes
Copy link
Contributor

@russjones russjones left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bot.

@russjones russjones self-requested a review March 25, 2021 03:18
a-palchikov
a-palchikov approved these changes Mar 25, 2021
View reviewed changes
@quinqu quinqu merged commit ceebd8f into master Mar 25, 2021
@quinqu quinqu deleted the jane/tshPlayFileArg branch March 25, 2021 20:03
@quinqu quinqu mentioned this pull request Mar 25, 2021
Merged
@quinqu quinqu mentioned this pull request Apr 20, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@a-palchikov a-palchikov a-palchikov approved these changes

@russjones russjones russjones approved these changes

@xacrimon xacrimon xacrimon approved these changes

@fspmarshall fspmarshall fspmarshall approved these changes

@klizhentas klizhentas Awaiting requested review from klizhentas

@r0mant r0mant Awaiting requested review from r0mant

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@quinqu @russjones @a-palchikov @xacrimon @fspmarshall