(v6) Fix --insecure-no-tls flag #5922
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 10, 2021
a-palchikov
approved these changes
Mar 10, 2021
| err = rc.CreateEx(nil, rcConf) | ||
| require.NoError(t, err) | ||
|
|
||
| err = rc.Start() |
There was a problem hiding this comment.
I wish the test could be reduced to this:
proxyConfig := newDefaultConfiguration()
// DisableTLS flag should turn off TLS termination and multiplexing.
proxyConfig.Proxy.DisableTLS = true
proxy := newTeleportInstance()
proxy.Start()
t.Cleanup(proxy.StopAll)
// Web proxy endpoint should just respond with 200 when called over http://,
// content doesn't matter.
resp, err := http.Get(fmt.Sprintf("http://%v", net.JoinHostPort(Loopback, rc.GetPortWeb())))
require.NoError(t, err)
require.NoError(t, resp.Body.Close())
klizhentas
approved these changes
Mar 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered that I broke
--insecure-no-tlsflag when updating proxy listeners to support db protocols in our multiplexer.This PR disables multiplexing if TLS is disabled, like it was before.