Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(6.0) Update release table to 6.0.0 #5838

Merged
merged 2 commits into from
Mar 10, 2021
Merged

(6.0) Update release table to 6.0.0 #5838

merged 2 commits into from
Mar 10, 2021

Conversation

r0mant
Copy link
Collaborator

@r0mant r0mant commented Mar 4, 2021

The release download table embedded in some pages was still using rc.1 release, update it to 6.0.0.

I manually tested all the links and they seemed to work.

@r0mant r0mant requested a review from klizhentas March 4, 2021 02:08
@r0mant r0mant self-assigned this Mar 4, 2021
@r0mant r0mant requested a review from russjones as a code owner March 4, 2021 02:08
@klizhentas
Copy link
Contributor

@r0mant please also forward-port the PR

@r0mant
Copy link
Collaborator Author

r0mant commented Mar 4, 2021

@klizhentas #5851

@webvictim
Copy link
Contributor

webvictim commented Mar 4, 2021

I'm curious why we're embedding a second set of links here, shouldn't we just be directing people off to https://goteleport.com/teleport/download? I could understand it during preview to make sure people got the correct version but now it's GA, the second set of links should probably go. It's another place we'd have to keep up to date when we introduce new versions.

@r0mant
Copy link
Collaborator Author

r0mant commented Mar 4, 2021

@webvictim Since these are "guides", I think the idea is to let people do as much as possible without leaving the page and not disrupt the flow. I'm not a fan of duplicating the links myself to be honest but I'm not aware of a decent (or any really) way to just embed our downloads table in the docs, which would probably be ideal. Maybe that's something that's on the grv/next roadmap? As a next best thing I think we could add a note here something along the lines of "or go to our Downloads page to pick an appropriate version" or something, in addition to the table?

@klizhentas Curious what you think as well ^

@klizhentas
Copy link
Contributor

I agree with @webvictim please point to downloads page

@r0mant
Copy link
Collaborator Author

r0mant commented Mar 8, 2021

@klizhentas Done.

@r0mant r0mant enabled auto-merge (squash) March 10, 2021 19:48
@r0mant r0mant merged commit efd34b3 into branch/v6 Mar 10, 2021
@r0mant r0mant deleted the roman/v6/table branch March 10, 2021 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants