mfa: add WithMFA to session-related audit events #5833
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awly
requested review from
alex-kovoy,
klizhentas,
r0mant and
russjones
as code owners
a-palchikov
approved these changes
Mar 4, 2021
andrejtokarcik
approved these changes
Mar 4, 2021
added 2 commits
March 4, 2021 11:24
Instead of just a bool, add the device UUID. This will be used in audit events when a session is started using MFA-issued certs.
Also extract a common function for parsing SSH certs.
awly
force-pushed
the
andrew/mfa-session-audit
branch
from
6831791 to
31b5f3b
Compare
awly
pushed a commit
that referenced
this pull request
Mar 25, 2021
* mfa: put device UUID in MFAVerified cert extensions Instead of just a bool, add the device UUID. This will be used in audit events when a session is started using MFA-issued certs. * Add WithMFA to session-related audit events Also extract a common function for parsing SSH certs.
awly
pushed a commit
that referenced
this pull request
Mar 29, 2021
* mfa: put device UUID in MFAVerified cert extensions Instead of just a bool, add the device UUID. This will be used in audit events when a session is started using MFA-issued certs. * Add WithMFA to session-related audit events Also extract a common function for parsing SSH certs.
awly
pushed a commit
that referenced
this pull request
Mar 29, 2021
* mfa: put device UUID in MFAVerified cert extensions Instead of just a bool, add the device UUID. This will be used in audit events when a session is started using MFA-issued certs. * Add WithMFA to session-related audit events Also extract a common function for parsing SSH certs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a session is started using a single-use cert after an MFA check, include the UUID of that MFA device in the audit events.
Had to refactor cert extensions to include the UUID and not just the bool. This is not used in the wild yet so it's safe to change the extension format.
Also extracted a common helper function for parsing SSH certs.