Fix db server test data race #5832
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
a-palchikov
approved these changes
Mar 3, 2021
| s.mu.Lock() | ||
| defer s.mu.Unlock() | ||
| // Make sure to return a new object, because it gets cached by | ||
| // heartbeat and will always compare as equal otherwise. |
There was a problem hiding this comment.
Following up on your comment - I believe heartbeat's code uses CompareServers to compare by value and not by reference but cloning is still required to avoid races.
There was a problem hiding this comment.
@a-palchikov Yes, it compares by value, but we'd be comparing the same object to itself every time if we didn't return a new one here. And yeah, data races too of course.
russjones
approved these changes
Mar 3, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#5829 forward-port.