Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed build failure for non-Linux platforms. #5800

Merged
merged 1 commit into from
Mar 1, 2021
Merged

Conversation

russjones
Copy link
Contributor

No description provided.

@webvictim
Copy link
Contributor

Why does this failure only occur on non-Linux platforms? Some kind of build constraint means that a file importing os doesn't get included on MacOS?

@russjones
Copy link
Contributor Author

russjones commented Mar 1, 2021

@webvictim This file is only built on non-Linux platforms. It was invalid from the start just never tested. We should really get CI running for macOS even if only a sanity check. Although we do have the sanity check that you built that alerted us! Thanks!

@webvictim webvictim merged commit 4f10255 into master Mar 1, 2021
@webvictim webvictim deleted the rjones/fix-uacc branch March 1, 2021 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants