Add "billing_information" RBAC resource #5676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-kovoy
requested review from
klizhentas,
r0mant and
russjones
as code owners
Joerger
approved these changes
Feb 23, 2021
r0mant
approved these changes
Feb 24, 2021
alex-kovoy
force-pushed
the
alexey/cloud
branch
from
94f2579 to
89beb68
Compare
russjones
reviewed
Feb 25, 2021
alex-kovoy
force-pushed
the
alexey/cloud
branch
from
89beb68 to
162c73d
Compare
klizhentas
approved these changes
Feb 25, 2021
|
@alex-kovoy any reason why you returned *auth.Client instead of the interface here? |
alex-kovoy
force-pushed
the
alexey/cloud
branch
3 times, most recently
from
fd87a16 to
4800d68
Compare
alex-kovoy
commented
Feb 27, 2021
| } | ||
|
|
||
| type registry struct { | ||
| plugins map[string]Plugin |
There was a problem hiding this comment.
This map is not going to be used concurrently as plugin registrations happen during the initialization time.
Btw, @klizhentas i am not happy with the package name plugin as it overlaps with other plugins (data). What if I name it as enterprise implying enterprise only extensions?
There was a problem hiding this comment.
I think either plugin or extensions is fine. I would stay away from enterprise
alex-kovoy
force-pushed
the
alexey/cloud
branch
from
4800d68 to
03cda0d
Compare
klizhentas
approved these changes
Feb 27, 2021
| } | ||
|
|
||
| type registry struct { | ||
| plugins map[string]Plugin |
There was a problem hiding this comment.
I think either plugin or extensions is fine. I would stay away from enterprise
alex-kovoy
force-pushed
the
alexey/cloud
branch
2 times, most recently
from
dbd53f6 to
386ffb5
Compare
alex-kovoy
added a commit
that referenced
this pull request
Mar 15, 2021
* Expose GRPC client connection to plugins * Replaces global plugin state with the PluginRegistry
alex-kovoy
added a commit
that referenced
this pull request
Mar 15, 2021
alex-kovoy
added a commit
that referenced
this pull request
Mar 16, 2021
* Expose GRPC client connection to plugins * Replaces global plugin state with the PluginRegistry
alex-kovoy
added a commit
that referenced
this pull request
Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds billing information RBAC resource and exposes several Auth Service methods to make it possible to register custom GRPC services (for auth plugin).
It's counterpart https://github.com/gravitational/teleport.e/pull/219