mfa: audit events for adding/removing devices #5665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awly
force-pushed
the
andrew/mfa-management-audit
branch
2 times, most recently
from
13ec59e to
b0e65da
Compare
Joerger
approved these changes
Feb 23, 2021
r0mant
reviewed
Feb 23, 2021
xacrimon
reviewed
Feb 23, 2021
xacrimon
approved these changes
Feb 23, 2021
awly
force-pushed
the
andrew/mfa-management-audit
branch
from
b0e65da to
25a62d5
Compare
|
@r0mant Do you mind re-reviewing? Since this is slated for 6.1 if you don't have time now it can wait till after 6.0 is out. |
awly
force-pushed
the
andrew/mfa-management-audit
branch
2 times, most recently
from
a2e2806 to
732d2ea
Compare
|
@r0mant please review |
r0mant
approved these changes
Mar 4, 2021
added 3 commits
March 4, 2021 08:53
Also add `With2FA` field to `UserLogin` when an MFA device is used during login.
awly
force-pushed
the
andrew/mfa-management-audit
branch
from
c61ed46 to
1b2c8c4
Compare
awly
pushed a commit
that referenced
this pull request
Mar 25, 2021
* mfa: audit events for adding/removing devices Also add `With2FA` field to `UserLogin` when an MFA device is used during login. * Address review feedback * mfa: reorganize audit event structure to be flat
awly
pushed a commit
that referenced
this pull request
Mar 29, 2021
* mfa: audit events for adding/removing devices Also add `With2FA` field to `UserLogin` when an MFA device is used during login. * Address review feedback * mfa: reorganize audit event structure to be flat
awly
pushed a commit
that referenced
this pull request
Mar 29, 2021
* mfa: audit events for adding/removing devices Also add `With2FA` field to `UserLogin` when an MFA device is used during login. * Address review feedback * mfa: reorganize audit event structure to be flat
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add
With2FAfield toUserLoginwhen an MFA device is usedduring login.