Machine ID: Warn when returned cert TTL is less than expected #52833
+43
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a warning when the returned certificate TTL is lower than requested, which can happen if `max_session_ttl` is set in a bot role. Fixes #29579
timothyb89
commented
Mar 6, 2025
| // Calculate a rough TTL, assuming this was called shortly after the | ||
| // identity was returned. We'll add a minute buffer to compensate and avoid | ||
| // superfluous warning messages. | ||
| effectiveTTL := ident.TLSIdentity.Expires.Sub(time.Now()) + time.Minute |
There was a problem hiding this comment.
A bit janky and may have some minor false negatives due to the 1m buffer. Hopefully sane enough?
Comment on lines
+432
to
+435
| l.WarnContext(ctx, "The server returned an identity shorter than "+ | ||
| "the requested TTL, probably due to a `max_session_ttl` "+ | ||
| "configured on a server-side role. It may not remain valid as "+ | ||
| "long as expected.") |
There was a problem hiding this comment.
I did some experimenting and found that bots can always fetch their own roles, so technically we could make some queries and log exactly which role caused the shortened TTL. Any thoughts on whether or not that would be worth the effort?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a warning when the returned certificate TTL is lower than requested, which can happen if
max_session_ttlis set in a bot role.Fixes #29579