Fix CGO-less TBot Build #52505
Merged
Fix CGO-less TBot Build #52505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hugoShaka
approved these changes
Feb 26, 2025
tigrato
approved these changes
Feb 27, 2025
public-teleport-github-review-bot
bot
removed the request for review
from bernardjkim
|
@strideynet See the table below for backport results.
|
strideynet
added a commit
that referenced
this pull request
Feb 27, 2025
* Fix CGOLess tbot build * Remove buildmode=pie for CGO_ENABLED=0 builds
strideynet
added a commit
that referenced
this pull request
Feb 27, 2025
* Fix CGOLess tbot build * Remove buildmode=pie for CGO_ENABLED=0 builds
bl-nero
pushed a commit
that referenced
this pull request
Feb 27, 2025
* Fix CGOLess tbot build * Remove buildmode=pie for CGO_ENABLED=0 builds
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #52101
Regression was introduced by #43877 - which switched from explicitly setting CGO_ENABLED=0, to leaving it unset. The Go compiler then used its discretion to decide to perform a CGO build, which, has caused issues for the Spacelift image which is based on Alpine and has no glibc.
changelog: Fixed
cannot execute: required file not founderror with theteleport-spacelift-runnerimage