Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFD 203 - Database Health Checks #52400

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

GavinFrazar
Copy link
Contributor

@GavinFrazar GavinFrazar commented Feb 21, 2025

@GavinFrazar GavinFrazar added rfd Request for Discussion no-changelog Indicates that a PR does not require a changelog entry labels Feb 21, 2025
@GavinFrazar GavinFrazar changed the title Initial draft RFD 203 - Database Health Checks Feb 21, 2025
@GavinFrazar GavinFrazar force-pushed the rfd/0203-database-healthchecks branch from 4b5a393 to 2372383 Compare February 21, 2025 22:00
@GavinFrazar GavinFrazar marked this pull request as ready for review February 21, 2025 22:00
@GavinFrazar GavinFrazar force-pushed the rfd/0203-database-healthchecks branch from 2372383 to a4cce8f Compare February 21, 2025 22:33
@GavinFrazar GavinFrazar force-pushed the rfd/0203-database-healthchecks branch from a4cce8f to 4fd0121 Compare February 21, 2025 23:16
3. improve troubleshooting
4. lay the groundwork for collecting agent->resource latency measurements that can be used to make routing decisions based on latency

Related issues:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


### Health status

Database target health status will be stored in the DB agent's ephemeral `db_server` heartbeat as the `spec.target_health` field.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be stored in status.target_health instead of spec?

Health checks should be opt-in to avoid issues for existing customers who upgrade.
However, our docs configuration references should have health checks enabled to encourage usage.

Users can change the default health check settings cluster-wide in `cluster_networking_config`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These settings will not persist in Cloud until #18829 is addressed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Indicates that a PR does not require a changelog entry rfd Request for Discussion size/lg
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants