tctl: always format resources as lists in JSON/YAML #4281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awly
requested review from
fspmarshall,
klizhentas,
russjones and
webvictim
as code owners
|
The original behavior was introduced in #652. |
|
OK, the original behavior was imitating the behavior of older |
|
I reviewed this with @russjones I think since it can potentially cause a breaking change for customers scripts we should add this 5.0 and list it as a potential breaking changes to customers automation scripts. |
|
Sounds good - should we close this for now, then reopen and merge it after we've cut the 4.4 branch? |
|
Let's keep it open, adding to the milestone is enough for now. |
awly
force-pushed
the
andrew/tctl-resource-formatting
branch
from
5e23069 to
1502a61
Compare
|
|
This makes it more practical for parsing (e.g. with `jq`). Also, refactor the formatting code because all JSON/YAML formatting is the same.
awly
force-pushed
the
andrew/tctl-resource-formatting
branch
from
1502a61 to
b9bb485
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it more practical for parsing (e.g. with
jq).Also, refactor the formatting code because all JSON/YAML formatting is
the same.