tctl: fix tctl top colors on dark terminals
#4231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awly
requested review from
fspmarshall,
klizhentas,
russjones and
webvictim
as code owners
If we leave `TextStyle` empty on UI elements, it will use the default foreground color defined by the terminal (light for dark terminals and vice versa). Same goes for `BorderStyle`. A few other tweaks to UI and source metrics: - update table ratios to prevent hiding output rows on short (height) terminal windows - update tab selector style to use bold/underline instead of colors to mark selected tab - print `No data` in histogram tables when there are no values - don't report the local cluster in `remote_clusters` metric
awly
force-pushed
the
andrew/tctl-top-colors
branch
from
f5fdcd7 to
9fc5edc
Compare
webvictim
approved these changes
Aug 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we leave
TextStyleempty on UI elements, it will use the defaultforeground color defined by the terminal (light for dark terminals and
vice versa). Same goes for
BorderStyle.A few other tweaks to UI and source metrics:
terminal windows
mark selected tab
No datain histogram tables when there are no valuesremote_clustersmetricBefore:
After:
Fixes #4049