Add check for empty ClusterNames, ServerHostname in retrieving sessions #4027
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kimlisa
requested review from
alex-kovoy,
awly,
fspmarshall,
russjones and
webvictim
as code owners
kimlisa
force-pushed
the
lisa/bw-comp-session-clusterName
branch
from
b123ac4 to
6e4fb72
Compare
webvictim
reviewed
Jul 13, 2020
fspmarshall
approved these changes
Jul 14, 2020
kimlisa
changed the title
kimlisa
changed the title
fspmarshall
approved these changes
Jul 15, 2020
lib/web/apiserver_test.go
Outdated
| c.Assert(err, IsNil) | ||
|
|
||
| var sessionList *siteSessionsGetResponse | ||
| json.Unmarshal(res.Bytes(), &sessionList) |
There was a problem hiding this comment.
Unmarshal returns an err which should be checked.
awly
approved these changes
Jul 15, 2020
kimlisa
pushed a commit
that referenced
this pull request
Jul 15, 2020
kimlisa
pushed a commit
that referenced
this pull request
Jul 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #4012
Description
Teleport node's running < v4.3 does not set ClusterName and ServerHostname for session info, which is needed to form session URL in the UI and to display information. This PR handles this incompatibility.
Manual Testing
Reproduced issue and tested with Proxy/Auth v4.3 with Node v4.2.11
Reliant PR
gravitational/webapps#123