Various buildbox/Drone fixes #3982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webvictim
force-pushed
the
gus/one-dockerfile-to-rule-them-all
branch
from
114756f to
3558b9c
Compare
|
retest this please |
awly
reviewed
Jul 7, 2020
There was a problem hiding this comment.
Can you also add PAM changes from https://github.com/gravitational/teleport/pull/3966/files#diff-e60f083cfee151a61e71f27ba4c92a0c ?
I've moved the PAM copy steps to the end of the Dockerfile so we can still make use of layer caching for the earlier stages. It also requires that we install a number of extra packages into the alpine container that's running |
|
retest this please |
|
retest this please |
webvictim
force-pushed
the
gus/one-dockerfile-to-rule-them-all
branch
2 times, most recently
from
1f23872 to
2c186b2
Compare
webvictim
force-pushed
the
gus/one-dockerfile-to-rule-them-all
branch
from
8a25e26 to
8dfb154
Compare
|
retest this please |
1 similar comment
|
retest this please |
webvictim
added a commit
that referenced
this pull request
Jul 10, 2020
webvictim
added a commit
that referenced
this pull request
Jul 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main purpose of this PR is to enable pulling and rebuiding the Teleport buildbox before each set of lint/unit test/integration test runs in the same way as Jenkins currently does. This is useful for us to be able to test
Dockerfilechanges, plus change the Go runtime and have that tested as part of PRs. It uses--cache-fromto aim for some bonusdocker buildspeed/layer caching.This PR also disables reuse of the Go build cache inside containers. The benefit to this is that tests seem to be more reliable. The downside is that test runs will take longer.
I also took out uses of the
$REPOvariable as we weren't using it properly anyway. If we change from quay.io to another repository then we'll likely need to update the image names/paths anyway.I added a load of other miscellaneous changes too:
buildbox-baseDockerfile code intobuild.assetsDockerfile (for simplicity/keeping everything in one place)bboxtobuildboxthroughoutMakefilefor claritybuild.assetsMakefilerather than explicitly laying it out in.drone.ymldebian:stretchtoubuntu:20.04(to keep everything up to date/free of vulnerabilities, plus a requirement to get a sufficiently recent BPF library version for tests)/gopathto/gothroughout Dockerfiles, for consistency with Drone and thegolangDocker imagesbuild.assets