Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v14] Simplify and fix Kubernetes Getting Started guide #38860

Merged
merged 3 commits into from
Mar 1, 2024

Conversation

ptgott
Copy link
Contributor

@ptgott ptgott commented Mar 1, 2024

Backport #38682 to branch/v14

ptgott added 3 commits March 1, 2024 17:03
Fixes #36026

- **Remove `kubernetes_users` in the example role**. Teleport
  impersonates a user with the Teleport user's name if the user has no
  `kubernetes_users` values, so don't provide one in this guide.

- **Remove the step to choose manual or guided enrollment**. The rest of
  the guide only shows the guided enrollment, making Step 1 redundant.

- **Reorder sections.**  Move the step to create RBAC resources first.
  This way, we can refer to the Kubernetes RBAC resources we created
  earlier when connecting to the cluster.

- **Condense redundant steps re: testing the connection:** There are two
  separate steps that test access to the cluster. Condense these
  instructions to simplify the guide.

- **Edit the "Set up and test access" section:** Include steps that more
  closely resemble the flow of the guide, including the namespace and
  groups to include in the "Test Connection" view.

- **Have the user fetch pods in the `teleport-agent` namespace**, since
  we created the namespace in the guide and can guarantee the output.
Responds to tigrato feedback
@ptgott ptgott added the no-changelog Indicates that a PR does not require a changelog entry label Mar 1, 2024
@github-actions github-actions bot requested review from tigrato and zmb3 March 1, 2024 17:05
@ptgott ptgott added this pull request to the merge queue Mar 1, 2024
Merged via the queue into branch/v14 with commit 5f52698 Mar 1, 2024
26 of 27 checks passed
@ptgott ptgott deleted the bot/backport-38682-branch/v14 branch March 1, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport documentation no-changelog Indicates that a PR does not require a changelog entry size/sm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants