Make agent channel setup lazy. #3741
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fspmarshall
requested review from
awly,
klizhentas,
russjones and
webvictim
as code owners
webvictim
reviewed
May 19, 2020
fspmarshall
force-pushed
the
fspmarshall/agent-hang-fix
branch
2 times, most recently
from
afa4587 to
8ecf6fc
Compare
awly
reviewed
May 20, 2020
russjones
reviewed
May 21, 2020
fspmarshall
force-pushed
the
fspmarshall/agent-hang-fix
branch
from
8ecf6fc to
c93a360
Compare
fspmarshall
force-pushed
the
fspmarshall/agent-hang-fix
branch
2 times, most recently
from
0741abc to
aabde17
Compare
|
retest this please |
fspmarshall
force-pushed
the
fspmarshall/agent-hang-fix
branch
2 times, most recently
from
3792be0 to
399b575
Compare
awly
reviewed
Jun 8, 2020
| // never actually be empty. | ||
| t.namespace = defaults.Namespace | ||
| } | ||
| cmt := check.Commentf("Test case %d: %+v", i, t) |
There was a problem hiding this comment.
optional: you can add a desc string field to the test cases to explain what the case covers instead of printing index + contents
There was a problem hiding this comment.
Cool, I wasn't aware of that feature. Think I'll keep as-is though; since I'm mutating the test case I think its nice to include a pretty print of the test case's value.
fspmarshall
force-pushed
the
fspmarshall/agent-hang-fix
branch
from
399b575 to
bd64b09
Compare
russjones
approved these changes
Jun 10, 2020
Changes agent channel setup behavior to be consistent openssh by having servers lazily request agent channels when they are needed, rather than immediately starting a single connection-wide channel as soon as forwarding is requested. Fixes an issue introduced in #3613 which caused openssh clients to hang on exit due to persistent agent channel.
fspmarshall
force-pushed
the
fspmarshall/agent-hang-fix
branch
from
bd64b09 to
fe98141
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes agent channel setup behavior to be consistent with openssh by having servers lazily request agent channels when they are needed, rather than immediately starting a single connection-wide channel as soon as forwarding is requested.
Fixes an issue introduced in #3613 which caused openssh clients to hang on exit due to persistent agent channel.