Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve test plan instructions for moderated sessions #37167

Merged

Conversation

strideynet
Copy link
Contributor

The current instructions are garbled due to GitHub inserting the #1 issue and #2 issues. It also felt generally unclear to me. Hopefully this is clearer.

Copy link

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

@strideynet strideynet added the no-changelog Indicates that a PR does not require a changelog entry label Jan 24, 2024
Copy link
Contributor

@tigrato tigrato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check my comment as it might be worth adding as an extra note

@strideynet strideynet added this pull request to the merge queue Jan 26, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 26, 2024
@strideynet strideynet added this pull request to the merge queue Jan 26, 2024
Merged via the queue into master with commit c9792b0 Jan 26, 2024
34 checks passed
@strideynet strideynet deleted the strideynet/improve-test-plan-for-moderated-sessions branch January 26, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog Indicates that a PR does not require a changelog entry size/sm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants