Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v14] Replace mermaid diagram, add guided instructions, remove includes wit… #35804

Merged
merged 6 commits into from
Dec 19, 2023
Merged

[v14] Replace mermaid diagram, add guided instructions, remove includes wit… #35804

merged 6 commits into from
Dec 19, 2023

Conversation

ptgott
Copy link
Contributor

@ptgott ptgott commented Dec 15, 2023

Backport #33554 to branch/v14

@github-actions GitHub Actions
Copy link

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

@ptgott ptgott force-pushed the bot/backport-33554-branch/v14 branch from 7d906f1 to f2af66c Compare December 15, 2023 22:05
@github-actions GitHub Actions
Copy link

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

@ptgott ptgott requested review from zmb3 and tigrato December 15, 2023 22:11
@ptgott ptgott added the no-changelog Indicates that a PR does not require a changelog entry label Dec 15, 2023
@ptgott ptgott force-pushed the bot/backport-33554-branch/v14 branch from f2af66c to 6aa5b5a Compare December 18, 2023 15:34
tigrato
tigrato reviewed Dec 19, 2023
View reviewed changes
docs/pages/kubernetes-access/getting-started.mdx
kubernetes_groups:
- viewers
kubernetes_users:
- <Var name="myuser"/>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is implicit if you don't have any kubernetes_users defined on all roles.
If you have multiple users defined it will fail so we shouldn't encourage people using it otherwise it will fail.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, the page already includes this change on master from the PR that this backports. I'll open a separate PR!

@ptgott ptgott force-pushed the bot/backport-33554-branch/v14 branch from 6aa5b5a to 9ef783d Compare December 19, 2023 14:44
@ptgott ptgott added this pull request to the merge queue Dec 19, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 19, 2023
@ptgott ptgott added this pull request to the merge queue Dec 19, 2023
Merged via the queue into branch/v14 with commit 73fb49b Dec 19, 2023
@ptgott ptgott deleted the bot/backport-33554-branch/v14 branch December 19, 2023 17:21
@ptgott ptgott mentioned this pull request Dec 22, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tigrato tigrato tigrato approved these changes

@zmb3 zmb3 zmb3 approved these changes

Assignees
No one assigned
Labels
backport documentation no-changelog Indicates that a PR does not require a changelog entry size/sm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ptgott @tigrato @zmb3 @lsgunn-teleport