Remove read/write timeouts to unbreak app access #34843
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with |
jakule
approved these changes
Nov 21, 2023
greedy52
approved these changes
Nov 21, 2023
rosstimothy
approved these changes
Nov 21, 2023
public-teleport-github-review-bot
bot
removed request for
gabrielcorado and
avatus
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#30248 broke application access scenarios with long-running requests. In our internal usage it affected our release publishing pipelines where publishing assets to a release server was timing out after 30 seconds. And customers have started to experiencing similar issues.
This PR removes read/write timeouts in places that affect application access requests. In addition to local testing, the fix was confirmed by upgrading app agent that serves release server to a dev version with this change and running a successful release.
Changelog: Fixed issue with application access requests and web UI large file downloads timing out after 30 seconds.