Pass localAuthEnabled flag to UI #3412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added LocalAuth prop to WebConfigAuthSetting struct in webconfig.go - Pass LocalAuth state as part of webCfg in apiserver.go
kimlisa
requested review from
r0mant,
alex-kovoy,
russjones and
fspmarshall
and removed request for
r0mant
fspmarshall
reviewed
Mar 6, 2020
lib/web/ui/webconfig.go
Outdated
| @@ -61,4 +61,6 @@ type WebConfigAuthSettings struct { | |||
| SecondFactor string `json:"second_factor,omitempty"` | |||
| // Providers contains a list of configured auth providers | |||
| Providers []WebConfigAuthProvider `json:"providers,omitempty"` | |||
| // LocalAuth enables/disables local logins | |||
| LocalAuth bool `json:"localAuth,omitempty"` | |||
There was a problem hiding this comment.
We typically use snake_case for JSON fields.
There was a problem hiding this comment.
webapps use camelCase :) (this is for webapi)
alex-kovoy
approved these changes
Mar 6, 2020
lib/web/ui/webconfig.go
Outdated
| @@ -61,4 +61,6 @@ type WebConfigAuthSettings struct { | |||
| SecondFactor string `json:"second_factor,omitempty"` | |||
| // Providers contains a list of configured auth providers | |||
| Providers []WebConfigAuthProvider `json:"providers,omitempty"` | |||
| // LocalAuth enables/disables local logins | |||
There was a problem hiding this comment.
// LocalAuth is a flag that enables local authentication
alex-kovoy
pushed a commit
that referenced
this pull request
Mar 12, 2020
* Added LocalAuthEnabled prop to WebConfigAuthSetting struct in webconfig.go * Added LocalAuthEnabled state as part of webCfg in apiserver.go
alex-kovoy
pushed a commit
that referenced
this pull request
Apr 14, 2020
* Added LocalAuthEnabled prop to WebConfigAuthSetting struct in webconfig.go * Added LocalAuthEnabled state as part of webCfg in apiserver.go
alex-kovoy
pushed a commit
that referenced
this pull request
Apr 15, 2020
* Added LocalAuthEnabled prop to WebConfigAuthSetting struct in webconfig.go * Added LocalAuthEnabled state as part of webCfg in apiserver.go
alex-kovoy
added a commit
that referenced
this pull request
Apr 15, 2020
* Add monorepo * Add reset/passwd capability for local users (#3287) * Add UserTokens to allow password resets * Pass context down through ChangePasswordWithToken * Rename UserToken to ResetPasswordToken * Add auto formatting for proto files * Add common Marshaller interfaces to reset password token * Allow enterprise "tctl" reuse OSS user methods (#3344) * Pass localAuthEnabled flag to UI (#3412) * Added LocalAuthEnabled prop to WebConfigAuthSetting struct in webconfig.go * Added LocalAuthEnabled state as part of webCfg in apiserver.go * update e-refs * Fix a regression bug after merge * Update tctl CLI output msgs (#3442) * Use local user client when resolving user roles * Update webapps ref * Add and retrieve fields from Cluster struct (#3476) * Set Teleport versions for node, auth, proxy init heartbeat * Add and retrieve fields NodeCount, PublicURL, AuthVersion from Clusters * Remove debug logging to avoid log pollution when getting public_addr of proxy * Create helper func GuessProxyHost to get the public_addr of a proxy host * Refactor newResetPasswordToken to use GuessProxyHost and remove publicUrl func * Remove webapps submodule * Add webassets submodule * Replace webapps sub-module reference with webassets * Update webassets path in Makefile * Update webassets 1b11b26 Simplify and clean up Makefile (#62) gravitational/webapps@1b11b26 * Retrieve cluster details for user context (#3515) * Let GuessProxyHost also return proxy's version * Unit test GuessProxyHostAndVersion & GetClusterDetails * Update webassets 4dfef4e Fix build pipeline (#66) gravitational/webapps@4dfef4e * Update e-ref * Update webassets 0647568 Fix OSS redirects gravitational/webapps@0647568 * update e-ref * Update webassets e0f4189 Address security audit warnings Updates "minimist" package which is used by 7y old "optimist". gravitational/webapps@e0f4189 * Add new attr to Session struct (#3574) * Add fields ServerHostname and ServerAddr * Set these fields on newSession * Ensure webassets submodule during build * Update e-ref * Ensure webassets before running unit-tests * Update E-ref Co-authored-by: Lisa Kim <[email protected]> Co-authored-by: Pierre Beaucamp <[email protected]> Co-authored-by: Jenkins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of issue #2789
tested in UI:
