-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for tls certificate update #3272
Conversation
Signed-off-by: binoue <[email protected]>
Can one of the admins verify this patch? |
ok to test |
setting expectations folks, the proposed design is very risky, as there is no explicit state machine for rolling this back in this design. I would want to have FSM like approach using signals similar to what we have for binary reloads. |
Thank you for reviewing! Therefore, if the certificate is invalid because of some operation, Considering that, we are not sure what risk this pull request has. |
Thank you for your replay.
Okey, I will try to fix this pull request as soon as possible |
I checked your links, code, and documents. In the original issue, a maintainer recognizes this as an important issue. |
@binoue Let's close this PR for now then. We don't have plans to address this at the moment, but we'll keep it in mind when planning the next milestone. |
This pull request addresses #3198.
In this pull request, the following changes are made.
tlsConfig.GetCertificate
handler to apply the loaded x509 certificate.