Partially revert #30248 #31945
Merged
Partially revert #30248 #31945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tigrato
added
test-plan-problem
zmb3
approved these changes
Sep 15, 2023
Closed
greedy52
approved these changes
Sep 15, 2023
public-teleport-github-review-bot
bot
removed request for
r0mant and
jentfoo
jentfoo
approved these changes
Sep 15, 2023
|
Can you confirm that neither timeout is able to be set? It could be worth adding a comment for the next time we stumble on this listener. |
Yes. We cannot set any of those parameters. |
tigrato
force-pushed
the
tigrato/fix-watchers-kube
branch
from
17f4300 to
efad2bf
Compare
jentfoo
approved these changes
Sep 15, 2023
This PR removes the `ReadTimeout` and `WriteTimeout` settings from `kube/proxy.Server`. The revert is required because both settings were terminating watch streams earlier and causing several when parsing the long lived data stream. Signed-off-by: Tiago Silva <[email protected]>
tigrato
force-pushed
the
tigrato/fix-watchers-kube
branch
from
efad2bf to
baaa44e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
ReadTimeoutandWriteTimeoutsettings fromkube/proxy.Server.The revert is required because both settings were terminating watch streams earlier and causing several issues when parsing the long-lived data stream.