Removed hardcoded access_keys #3072
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webvictim
reviewed
Oct 9, 2019
There was a problem hiding this comment.
I'm unsure whether the ${} syntax makes it easier to understand. It might be best to use things like example-table-name to make it very clear that people have to replace this themselves.
(certainly until we get some kind of coloured highlighting for examples/things to replace)
Closed
|
^ Thanks Gus, I've updated it and also added a reference for the DynamoDB regions. |
webvictim
reviewed
Oct 9, 2019
| secret_key: Oc20333k293SKwzraT3ah3Rv1G3/97POQb3eGziSZ | ||
| # table_name is | ||
| table_name: Example_TELEPORT_DYNAMO_TABLE_NAME | ||
| audit_table_name: Example_TELEPORT_DYNAMO_EVENTS_TABLE_NAME | ||
|
|
||
| # This setting configures Teleport to send the audit events to three places: | ||
| # To keep a copy on a local filesystem, in DynamoDB and to Stdout. | ||
| audit_events_uri: ['file:///var/lib/teleport/audit/events', 'dynamodb://table_name', 'stdout://'] |
There was a problem hiding this comment.
(this is the 'new' way of storing events to DynamoDB)
There was a problem hiding this comment.
Sorry @webvictim not sure if this a note / comment. If I should update let me know.
|
K, thanks @webvictim I've made those changes. |
klizhentas
reviewed
Oct 9, 2019
klizhentas
reviewed
Oct 9, 2019
klizhentas
reviewed
Oct 9, 2019
|
Sorry for the delay on turning this around. It's ready for a review now. |
klizhentas
reviewed
Oct 17, 2019
klizhentas
approved these changes
Oct 18, 2019
one000mph
pushed a commit
to andyet/teleport
that referenced
this pull request
Oct 20, 2019
* Removed hardcoded aws access_keys in favour of customers using IAM and aws credentials.
one000mph
pushed a commit
to andyet/teleport
that referenced
this pull request
Oct 20, 2019
* Removed hardcoded aws access_keys in favour of customers using IAM and aws credentials.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting to fix #3071