tsh request search displays discovered resource name
#30196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GavinFrazar
added
ux
kubernetes-access
tsh
smallinsky
approved these changes
Aug 9, 2023
tigrato
approved these changes
Aug 9, 2023
public-teleport-github-review-bot
bot
removed request for
ravicious and
rudream
* factor out discovered name func from tsh and tctl into tool/common
GavinFrazar
force-pushed
the
gavinfrazar/tsh-request-search-display-ux
branch
from
7d9e12d to
faa20f1
Compare
|
@GavinFrazar See the table below for backport results.
|
GavinFrazar
added a commit
that referenced
this pull request
Sep 16, 2023
backports #30196 to branch/v13. * factor out discovered name func from tsh and tctl into tool/common
GavinFrazar
added a commit
that referenced
this pull request
Sep 18, 2023
backports #30196 to branch/v13. * factor out discovered name func from tsh and tctl into tool/common
GavinFrazar
added a commit
that referenced
this pull request
Sep 18, 2023
backports #30196 to branch/v13. * factor out discovered name func from tsh and tctl into tool/common
GavinFrazar
added a commit
that referenced
this pull request
Sep 18, 2023
* [v13] show discovered name in non-verbose request search backports #30196 to branch/v13. * factor out discovered name func from tsh and tctl into tool/common * [v13] tctl resource selection ux (#32086) backports #30081 to branch/v13. * prefix matching for tctl get discovery resources: * kube_cluster * kube_server * db * db_server * skip 500ms wait for 0 databases in tests
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 19, 2023
* [v13] show discovered name in tsh kube ls backports #30149 to branch/v13. * update tsh kube ls tests * fix SiteName godoc typo * [v13] `tsh request search` displays discovered resource name (#32085) * [v13] show discovered name in non-verbose request search backports #30196 to branch/v13. * factor out discovered name func from tsh and tctl into tool/common * [v13] tctl resource selection ux (#32086) backports #30081 to branch/v13. * prefix matching for tctl get discovery resources: * kube_cluster * kube_server * db * db_server * skip 500ms wait for 0 databases in tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes
tsh request searchdisplay an auto-discovered resource by its original discovered name instead of the full name as it was renamed by discovery service (in non-verbose mode). In verbose mode it shows the full name.I also factored out discovered name func from tsh and tctl into tool/common
stacked on #30149
Part of the implementation for RFD 129.
Related issue:
Changelog:
tsh request searchin non-verbose mode will display auto-discovered resources with original resource names instead of the more detailed names generated by the v14+ Teleport Discovery service.