apiserver: Remove rate limiting on /webapi/find endpoint #27747
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was discovered in recent load testing that our high rate limit was still potentially impactful. After discussions we decided that because of the low load impacts from this endpoint it's probably safest to just avoid rate limiting for the `find` endpoint.
jentfoo
requested review from
r0mant,
espadolini,
zmb3,
codingllama and
rosstimothy
rosstimothy
approved these changes
Jun 12, 2023
zmb3
approved these changes
Jun 12, 2023
public-teleport-github-review-bot
bot
removed request for
r0mant,
jimbishopp,
espadolini and
codingllama
Co-authored-by: Zac Bergquist <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was discovered in recent load testing that our high rate limit was still potentially impactful. After discussions with @espadolini we decided that because of the low load impacts from this endpoint it's probably safest to just avoid rate limiting for the
findendpoint.The addition of these rate limits is still only in
master, originally implemented in this PR: #24623