Run webassets build in Docker as current OS user #20426
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codingllama
approved these changes
Jan 19, 2023
zmb3
approved these changes
Jan 19, 2023
espadolini
approved these changes
Jan 19, 2023
|
Can you backport this to v12 as well plz. |
hatched
pushed a commit
that referenced
this pull request
Jan 31, 2023
Set the current user when running webassets builds. In this way, the build artifacts will have correct permissions.
hatched
added a commit
that referenced
this pull request
Jan 31, 2023
* Move tsconfig.json to root dir, remove web Makefile and Dockerfile (#20399) * Move tsconfig.json to root dir At the moment, it looks like the TS language server has problems with recognizing imports when editing files inside e/web. I figured this is probably because tsconfig.json is in web, so the lang server doesn't recognize it when editing files from e/web. * Remove web/Dockerfile and web/Makefile * Misc updates to readme * Fix links in readme * Remove web/packages/build from ignored files (#20400) * Run webassets build in Docker as current OS user (#20426) Set the current user when running webassets builds. In this way, the build artifacts will have correct permissions. * Add .prettierrc to teleport root (#20448) * Add nodejs to the fips dockerfile. (#20487) * Add BUILDARCH arg to fips dockerfile. (#20495) * Update xterm-addon-fit (#20696) This resolves an issue when starting an SSH session from the web UI, and also fixes the out-of-date lock file. * Move storybook to root package.json and fix config so e components are rendered. (#20723) * Resolve issues to enable passing CI tests. (#20582) * Move lint commands to root package.json * Correctly resolve e-teleport paths. * Fix prettier issues. * move eslint configuration files to root. * resolve lint errors. * bump e * Move jest, eslint & prettier to the root (#20698) * Move jest, eslint & prettier to the root * Update e ref --------- Co-authored-by: Rafał Cieślak <[email protected]> Co-authored-by: Jakub Nyckowski <[email protected]> Co-authored-by: Michael <[email protected]> Co-authored-by: Zac Bergquist <[email protected]> Co-authored-by: Ryan Clark <[email protected]>
hatched
pushed a commit
that referenced
this pull request
Feb 3, 2023
Set the current user when running webassets builds. In this way, the build artifacts will have correct permissions.
hatched
added a commit
that referenced
this pull request
Feb 3, 2023
* Changes necessary to get v10 building after the webapps merge. * move tsconfig.json to root dir, remove web makefile and dockerfile. * Remove web/packages/build from ignored files (#20400) * Run webassets build in Docker as current OS user (#20426) Set the current user when running webassets builds. In this way, the build artifacts will have correct permissions. * Add .prettierrc to teleport root (#20448) * Add nodejs to the fips dockerfile. (#20487) * Conditionally build the UI if there are changes. (#20489) * Conditionally build the UI if there are changes. `ensure-webassets` and `ensure-webassets-e` will now build the UI if the hash-of-hashes has changed since the last time the webassets were built. * Update Makefile Co-authored-by: Jeff Pihach <[email protected]> * Check for the existence of the make command. * Choose a shasum exec from a preconfigured list or use an override. * Shellcheck fix. * Remove yarn.lock from sha calculation. * Recalc SHA on successful build. * Fix linting issues. * Use Python instead of shasum. * Remove unnecessary comments from sh file. * Unconditionally rebuild if Python executable is not found. * Revert "Unconditionally rebuild if Python executable is not found." This reverts commit 9d2b0e3. * Revert "Remove unnecessary comments from sh file." This reverts commit 600e028. * Revert use of Python, use simplified shell scripting. * Linting fixes. * Apply suggestions from code review Co-authored-by: Edoardo Spadolini <[email protected]> * Remove reference to realpath as apparently the MacOS builder doesn't have it. * calculate_sha must return 0. * Use echo in calculate_sha or else set -o pipefail causes failures. * Suppress SC2005. --------- Co-authored-by: Jeff Pihach <[email protected]> Co-authored-by: Edoardo Spadolini <[email protected]> * Add BUILDARCH arg to fips dockerfile. (#20495) * Resolve issues to enable passing CI tests. (#20582) * Move lint commands to root package.json * Correctly resolve e-teleport paths. * Fix prettier issues. * move eslint configuration files to root. * resolve lint errors. * Update xterm-addon-fit (#20696) This resolves an issue when starting an SSH session from the web UI, and also fixes the out-of-date lock file. * Move jest, eslint & prettier to the root (#20698) * Move jest, eslint & prettier to the root * Update e ref * Move storybook to root package.json and fix config so e components are rendered. (#20723) * update yarn lock. --------- Co-authored-by: Rafał Cieślak <[email protected]> Co-authored-by: Jakub Nyckowski <[email protected]> Co-authored-by: Michael <[email protected]> Co-authored-by: Michael Wilson <[email protected]> Co-authored-by: Edoardo Spadolini <[email protected]> Co-authored-by: Zac Bergquist <[email protected]> Co-authored-by: Ryan Clark <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set the current user when running webassets builds. In this way, the build artifacts will have correct permissions.