Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added multiarch Teleport Lab support #18015

Draft
wants to merge 33 commits into
base: master
Choose a base branch
from

Conversation

fheinecke
Copy link
Contributor

@fheinecke fheinecke commented Nov 1, 2022

This is the third and final part of a series of feature PRs updating drone/dronegen to support multiarch builds.

The primary purpose of this PR is to add multiarch Teleport Lab container images. This includes amd64, arm, and arm64 images under the $MAJOR_VERSION tag on each release.

This includes three sets of minor changes outside of Teleport Lab specific dronegen changes:

  • Refactored the Teleport Lab dockerfile to be based on the locally built Teleport images. This does not require any Makefile changes as we have no Makefile targets for Teleport Lab.
  • Refactored a couple of container image functions:
    • downloadTeleportDockerfileStep was renamed to downloadDockerfileStep and the produced step name was simplified due to Drone step name length limitations
    • If Product ArchSetupSteps contain no commands, then the empty step is not added to the pipeline but treated as a dependency step
  • Removed these pipelines in their entirety as their functionality has been completely replaced by the new container image pipelines:
    • teleport-docker-cron
    • teleport-docker-cron-ecr

Per usual there is a large number of .drone.yml changes. Here's a breakdown of what changed:

  • 226 lines of old pipelines were removed
  • 16 lines were changed downloadTeleportDockerfileStep refactoring
  • 204 lines were added to the pipeline that builds new images
  • 396 lines were added to the pipeline that pulls/pushes images to production registries upon promotion
  • 619 lines were added to the pipeline that rebuilds/updates images across all repos, per each of the last three major versions, totaling 1857 lines
  • The remaining lines appear to be due to git diff matching up the two file versions in different places. See here for an example.

Related PRs:

Test runs prior to merging PR:

@fheinecke
Copy link
Contributor Author

This PR is suspended pending a resolution to the drone.yml file size limitation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant