-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added multiarch Teleport Lab support #18015
Draft
fheinecke
wants to merge
33
commits into
master
Choose a base branch
from
fred/multiarch-teleport-lab-container-images
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit cbe2692.
This PR is suspended pending a resolution to the drone.yml file size limitation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the third and final part of a series of feature PRs updating drone/dronegen to support multiarch builds.
The primary purpose of this PR is to add multiarch Teleport Lab container images. This includes amd64, arm, and arm64 images under the
$MAJOR_VERSION
tag on each release.This includes three sets of minor changes outside of Teleport Lab specific dronegen changes:
downloadTeleportDockerfileStep
was renamed todownloadDockerfileStep
and the produced step name was simplified due to Drone step name length limitationsArchSetupSteps
contain no commands, then the empty step is not added to the pipeline but treated as a dependency stepPer usual there is a large number of
.drone.yml
changes. Here's a breakdown of what changed:downloadTeleportDockerfileStep
refactoringgit diff
matching up the two file versions in different places. See here for an example.Related PRs:
Test runs prior to merging PR: