Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Signup URL #1689

Merged
merged 1 commit into from
Feb 16, 2018
Merged

Update Signup URL #1689

merged 1 commit into from
Feb 16, 2018

Conversation

russjones
Copy link
Contributor

Purpose

To better support HA configurations instead of trying to find out which proxy the user should connect to, print <proxyhost> and tell the user to make sure the proxy is accessible.

Implementation

  • Changed the signup message.

Related Issues

Fixes #1643

@russjones russjones requested a review from kontsevoy February 15, 2018 22:01
@klizhentas
Copy link
Contributor

this seems backwards, I think we should add proper public addr there instead of replacing it back with placeholder

@kontsevoy
Copy link
Contributor

@klizhentas we've discussed this internally, this is supposed to be a host name, not an IP address, for which we do not have a config. setting for (and adding one for printing these URLs) would be silly. Simply stating that makes it perfectly clear to admins what needs to be done.

@russjones russjones force-pushed the rjones/fix-proxy-url branch from 6681517 to 2cf7656 Compare February 16, 2018 22:00
@russjones russjones merged commit 03377b7 into master Feb 16, 2018
@russjones russjones deleted the rjones/fix-proxy-url branch February 16, 2018 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants