Added role option "cert_format" to control certificate generation #1559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kontsevoy
approved these changes
Jan 9, 2018
klizhentas
approved these changes
Jan 9, 2018
russjones
force-pushed
the
rjones/role-compat
branch
from
3fe9dc8 to
b3d4d36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Add an option in the role for how the certificate is generated. Also allow passing in the same option to override the behavior in the role.
Implementation
cert_formatas as a role option. The default value isstandard.cert_formatwhen requesting a user certificate. If a value is passed in, that is used. If no value is passed in, the value in the role is used.Related Issues
Fixes #1542