Trims the buildbox #14036
Merged
Trims the buildbox #14036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Enables the docker BuildKit in an attempt to speed up builds - Trims ~1GB off image size
webvictim
reviewed
Jul 1, 2022
zmb3
approved these changes
Jul 1, 2022
|
@tcsc could you include |
r0mant
reviewed
Jul 1, 2022
- Break more dependencies out into separate build stages - Add some simple supply-chain protections for dependencies sourced via git. The Docker build now checks that the commit SHAs are what we expect, and not just assume that the tags haven't changed. - Moves the `cbindgen` build to a stage to avoid pulling in extra dependencies not needed for the Teleport build - Combines the `gcloud` and firestore emulator install into one step to reduce the layer count. - Ports some of the above the Centos7 Dockerfile.
…o tcsc/trim-buildbox-buildkit
nklaassen
approved these changes
Jul 4, 2022
webvictim
reviewed
Jul 5, 2022
build.assets/Makefile
Outdated
| @@ -121,7 +121,7 @@ build-binaries-fips: buildbox-fips | |||
| buildbox: | |||
| if [[ "$(BUILDBOX_NAME)" == "$(BUILDBOX)" ]]; then \ | |||
| if [[ $${DRONE} == "true" ]] && ! docker inspect --type=image $(BUILDBOX) 2>&1 >/dev/null; then docker pull $(BUILDBOX) || true; fi; \ | |||
| docker build --platform=linux/$(RUNTIME_ARCH) \ | |||
| DOCKER_BUILDKIT=1 docker build --platform=linux/$(RUNTIME_ARCH) \ | |||
There was a problem hiding this comment.
There’s also a leading space here; doesn’t make any difference to the way it runs, just can’t unsee it 😁
webvictim
approved these changes
Jul 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables the docker BuildKit in an attempt to speed up builds, and trims just under 2GB off the image size.
Prior to these changes,
docker image lsreported the image as 6.08GB after a local build, and5.06GB4.17GB afterSee-Also: #6149