Backport lib/utils/prompt improvements to [v9] #13822
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
prompt.ContextReader
, along with various parts oflib/utils/prompt
, where re-written in master so we can alleviate input swallowing issues.For various reasons I didn't backport all changes to v9, but the less-eager input-swallowing loop is now what stands between us and issue #13021.
This isn't a backport of a specific PR, but instead a port of the entire
lib/utils/prompt
package, as the PRs that touch the package unfortunately do more than we want to backport. The interfaces are still compatible and I did test varioustsh login
andtsh ssh
scenarios.I've thrown in #13382 for good measure, as well.
Closes #13021.