Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v9] Check for unimplemented error during stream receive in Client.GetAccessRequests #13490

Merged
merged 6 commits into from
Jun 14, 2022

Conversation

xacrimon
Copy link
Contributor

Backport #13459 to branch/v9

@xacrimon xacrimon requested review from r0mant and zmb3 June 14, 2022 19:38
@github-actions github-actions bot requested a review from codingllama June 14, 2022 19:38
@r0mant r0mant enabled auto-merge (squash) June 14, 2022 19:39
@r0mant
Copy link
Collaborator

r0mant commented Jun 14, 2022

@xacrimon Linter fails on this PR:

client/client_test.go:754:16: m.NewClient undefined (type *mockAccessRequestServer has no field or method NewClient) (typecheck)
	clt, err := m.NewClient(ctx)
	              ^
client/client_test.go:741:4: unknown field `addr` in struct literal (typecheck)
			addr:                           l.Addr().String(),
			^
client/client_test.go:754:16: m.NewClient undefined (type *mockAccessRequestServer has no field or method NewClient) (typecheck)
	clt, err := m.NewClient(ctx)
	              ^
client/client_test.go:741:4: unknown field `addr` in struct literal (typecheck)
			addr:                           l.Addr().String(),
			^
client/client_test.go:754:16: m.NewClient undefined (type *mockAccessRequestServer has no field or method NewClient) (typecheck)
	clt, err := m.NewClient(ctx)

@r0mant r0mant disabled auto-merge June 14, 2022 20:00
@xacrimon
Copy link
Contributor Author

@r0mant Backported the needed utilities to make this test run.

@r0mant r0mant enabled auto-merge (squash) June 14, 2022 20:47
@r0mant r0mant merged commit 1a22034 into branch/v9 Jun 14, 2022
@r0mant r0mant deleted the bot/backport-13459-branch/v9 branch June 14, 2022 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants