Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Client timeout fixes #12557

Merged
merged 5 commits into from
May 13, 2022
Merged

Client timeout fixes #12557

merged 5 commits into from
May 13, 2022

Conversation

espadolini
Copy link
Contributor

@espadolini espadolini commented May 10, 2022

This PR fixes a couple of connectivity issues caused by either the lack of a timeout (in api/client/webclient) or timeout settings being ignored in certain situations (in lib/utils/proxy).

@espadolini espadolini force-pushed the espadolini/client-timeouts branch 2 times, most recently from 6b1bf16 to 27fdfe5 Compare May 12, 2022 17:17
@espadolini espadolini force-pushed the espadolini/client-timeouts branch from 27fdfe5 to 768e54e Compare May 12, 2022 18:11
@espadolini espadolini marked this pull request as ready for review May 12, 2022 18:11
@github-actions github-actions bot requested review from codingllama and ravicious May 12, 2022 18:12
Copy link
Contributor

@codingllama codingllama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a PR description, however brief it may be.

@espadolini
Copy link
Contributor Author

Please add a PR description, however brief it may be.

Sorry, I marked as ready for review and then got distracted 😅

@espadolini espadolini merged commit 3de0f5d into master May 13, 2022
@github-actions
Copy link

@espadolini See the table below for backport results.

Branch Result
branch/v7 Failed
branch/v8 Failed
branch/v9 Failed

@espadolini espadolini deleted the espadolini/client-timeouts branch May 13, 2022 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants