Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Database CA - trusted cluster changes #11615

Merged
merged 9 commits into from
Apr 4, 2022
Merged

Database CA - trusted cluster changes #11615

merged 9 commits into from
Apr 4, 2022

Conversation

jakule
Copy link
Contributor

@jakule jakule commented Mar 31, 2022 •
edited
Loading

This PR contains fixes to #9593 mainly around DatabaseCA trusted cluster rotation.

@jakule jakule requested review from r0mant and smallinsky March 31, 2022 16:15
espadolini
espadolini approved these changes Apr 1, 2022
View reviewed changes
Copy link
Contributor

@espadolini espadolini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rotation stuff LGTM; I'd check if the rotation-related tests are stable, however - either here or in jakule/database-ca.

@jakule jakule merged commit dbebf81 into jakule/database-ca Apr 4, 2022
@jakule jakule deleted the jakule/database-ca-trusted-cluster branch April 4, 2022 15:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@espadolini espadolini espadolini approved these changes

@smallinsky smallinsky smallinsky approved these changes

@r0mant r0mant Awaiting requested review from r0mant

@rosstimothy rosstimothy Awaiting requested review from rosstimothy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jakule @espadolini @smallinsky