-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add grpc server and client metrics to Teleport #11534
Conversation
e2040ea
to
2760456
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Could you add the new Metrics config items to TestConfigReading before merging?
@@ -63,6 +65,8 @@ type TLSServerConfig struct { | |||
AcceptedUsage []string | |||
// ID is an optional debugging ID | |||
ID string | |||
// Metrics are optional TLSServer metrics | |||
Metrics *Metrics |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this wasn't a pointer you could rely on default values to do the right thing at the moment since Metrics
only contains one boolean. If Metrics
was to be extended in the future then relying on default values wouldn't work so maybe it's fine to leave as it is.
Adds grpc metrics on the auth and and proxy service with the option to enable grpc latency via the metrics service.
This is part of https://github.com/gravitational/cloud/issues/1468
This add grpc client metrics to the Proxy service and server metrics to the Auth service via a grpc interceptor. By default these metrics are lazy loaded and latency is disabled by default. The latency metrics are turned off by default as they are high cardinality. Users can enable them enabling the
metrics_service
using the following stanza:I went back and forth on having these in their respective service stanzas, it might be more clear if they configured in their respective service and will change if feedback agrees.
Documentation is missing from this PR which I will add once I have feedback on rest to avoid having to make the changes twice.
Mock up dashboard with these can be seen here (still WIP)