Return errors from GetSession #1061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kontsevoy The only thing I am a little concerned with in this PR is that this might be expected behavior and this PR will break things unexpectedly. In a couple of places in the code it seems we look for |
kontsevoy
requested changes
Jun 9, 2017
|
@russjones well... even if we return an error now, the returned session is still |
russjones
force-pushed
the
rjones/fix-err-check
branch
from
0ff29e2 to
97b5b8f
Compare
|
@kontsevoy I think we're logging it on some code paths. When I force an error in |
kontsevoy
approved these changes
Jun 10, 2017
hatched
pushed a commit
to hatched/teleport-merge
that referenced
this pull request
Nov 30, 2022
If '0' is provided as the default and the initial call to create a gateway fails, the user will be presented with an input that says 0. 0 is an invalid value though that this input will not accept. An empty string, on the other hand, is a perfectly valid value (the input doesn't have the `required` attribute). In that scenario, the backend will default the value to '0' and pick a random port.
hatched
pushed a commit
that referenced
this pull request
Dec 20, 2022
If '0' is provided as the default and the initial call to create a gateway fails, the user will be presented with an input that says 0. 0 is an invalid value though that this input will not accept. An empty string, on the other hand, is a perfectly valid value (the input doesn't have the `required` attribute). In that scenario, the backend will default the value to '0' and pick a random port.
hatched
pushed a commit
that referenced
this pull request
Feb 1, 2023
If '0' is provided as the default and the initial call to create a gateway fails, the user will be presented with an input that says 0. 0 is an invalid value though that this input will not accept. An empty string, on the other hand, is a perfectly valid value (the input doesn't have the `required` attribute). In that scenario, the backend will default the value to '0' and pick a random port.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
GetSession()was hiding errors, this PR changes this behavior by returning errors other thantrace.NotFounderrors.Implementation
GetSessionto return nontrace.NotFounderrors.GetSessionsto propagate errors (this way we don't try and append anilsession to a slice).pollAndSyncpropagate the error if either we have an error or if the session isnil.Related Issues
Fixes #1002