-
Notifications
You must be signed in to change notification settings - Fork 1.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
panic in proto merge when deep-copying server value #5691
Labels
Comments
a-palchikov
added a commit
that referenced
this issue
Feb 25, 2021
manual implementation to avoid issues with proto-based type merge panics. Fixes #5691.
a-palchikov
added a commit
that referenced
this issue
Feb 26, 2021
manual implementation to avoid issues with proto-based type merge panics. Fixes #5691.
a-palchikov
added a commit
that referenced
this issue
Mar 4, 2021
manual implementation to avoid issues with proto-based type merge panics. Fixes #5691.
russjones
pushed a commit
that referenced
this issue
Mar 12, 2021
manual implementation to avoid issues with proto-based type merge panics. Fixes #5691.
russjones
pushed a commit
that referenced
this issue
May 1, 2021
manual implementation to avoid issues with proto-based type merge panics. Fixes #5691.
russjones
pushed a commit
that referenced
this issue
May 1, 2021
manual implementation to avoid issues with proto-based type merge panics. Fixes #5691.
This was referenced May 1, 2021
Merged
russjones
pushed a commit
that referenced
this issue
May 4, 2021
manual implementation to avoid issues with proto-based type merge panics. Fixes #5691.
russjones
pushed a commit
that referenced
this issue
May 4, 2021
manual implementation to avoid issues with proto-based type merge panics. Fixes #5691.
inertial-frame
pushed a commit
that referenced
this issue
May 6, 2021
manual implementation to avoid issues with proto-based type merge panics. Fixes #5691.
inertial-frame
pushed a commit
that referenced
this issue
May 6, 2021
manual implementation to avoid issues with proto-based type merge panics. Fixes #5691.
inertial-frame
pushed a commit
that referenced
this issue
May 6, 2021
manual implementation to avoid issues with proto-based type merge panics. Fixes #5691.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
What happened:
Very often, local integrations tests fail with:
The changes I made to mitigate another server test race by patching gogo implementation of proto.Clone does not seem to have the necessary effect.
The issue at hand is described here.
I'm going to rewrite the deep copy code without
proto.Clone
as it seems to be entirely unsuited for our needs.What you expected to happen:
No panic.
Reproduction Steps
The text was updated successfully, but these errors were encountered: