Skip to content

Commit

Permalink
defaults.go: LimiterPasswordless variables rename
Browse files Browse the repository at this point in the history
  • Loading branch information
jentfoo committed Apr 18, 2023
1 parent 289b611 commit 2f417cc
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 14 deletions.
6 changes: 3 additions & 3 deletions lib/auth/middleware.go
Original file line number Diff line number Diff line change
Expand Up @@ -383,9 +383,9 @@ func getCustomRate(endpoint string) *ratelimit.RateSet {
return rates
// Passwordless RPCs (potential unauthenticated challenge generation).
case "/proto.AuthService/CreateAuthenticateChallenge":
const period = defaults.LimiterPasswordlessPeriod
const average = defaults.LimiterPasswordlessAverage
const burst = defaults.LimiterPasswordlessBurst
const period = defaults.LimiterPeriod
const average = defaults.LimiterAverage
const burst = defaults.LimiterBurst
rates := ratelimit.NewRateSet()
if err := rates.Add(period, average, burst); err != nil {
log.WithError(err).Debugf("Failed to define a custom rate for rpc method %q, using default rate", endpoint)
Expand Down
15 changes: 7 additions & 8 deletions lib/defaults/defaults.go
Original file line number Diff line number Diff line change
Expand Up @@ -362,15 +362,14 @@ const (
LimiterMaxConcurrentSignatures = 10
)

// Default rate limits for unauthenticated passwordless endpoints.
// Default rate limits for unauthenticated endpoints.
const (
// LimiterPasswordlessPeriod is the default period for passwordless limiters.
LimiterPasswordlessPeriod = 1 * time.Minute
// LimiterPasswordlessAverage is the default average for passwordless
// limiters.
LimiterPasswordlessAverage = 20
// LimiterPasswordlessBurst is the default burst for passwordless limiters.
LimiterPasswordlessBurst = 40
// LimiterPeriod is the default period for unauthenticated limiters.
LimiterPeriod = 1 * time.Minute
// LimiterAverage is the default average for unauthenticated limiters.
LimiterAverage = 20
// LimiterBurst is the default burst for unauthenticated limiters.
LimiterBurst = 40
)

const (
Expand Down
6 changes: 3 additions & 3 deletions lib/web/apiserver.go
Original file line number Diff line number Diff line change
Expand Up @@ -336,9 +336,9 @@ func NewHandler(cfg Config, opts ...HandlerOption) (*APIHandler, error) {
h.limiter, err = limiter.NewRateLimiter(limiter.Config{
Rates: []limiter.Rate{
{
Period: defaults.LimiterPasswordlessPeriod,
Average: defaults.LimiterPasswordlessAverage,
Burst: defaults.LimiterPasswordlessBurst,
Period: defaults.LimiterPeriod,
Average: defaults.LimiterAverage,
Burst: defaults.LimiterBurst,
},
},
MaxConnections: defaults.LimiterMaxConnections,
Expand Down

0 comments on commit 2f417cc

Please sign in to comment.