This repository was archived by the owner on Jan 8, 2025. It is now read-only.
Fix 404 docs link #440
Merged
Fix 404 docs link #440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
ptgott
approved these changes
Mar 7, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 404 page for docs is using
<Link href="/docs/">to generate a link to the top of documentation page. This is incorrect:<Link ...>is already resolved relative to the top URL for docs, which means in practice this is a link to/docs/docs, which doesn't exist.Live repro: https://goteleport.com/docs/dummy/.
This also affects local development, where 404 page on
http://localhost:3000redirects you to non-existing pagehttp://localhost:3000/docs/docs.