Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Trim down CCN proposal #1358

Merged
merged 2 commits into from
Aug 3, 2023

Conversation

calvincestari
Copy link
Contributor

This trims down the Client-Controlled Nullability proposal back to the most basic form. This is a result of recent CCN sub-WG meetings trying to progress the proposal through the stages.

More detail to come in the August 3, 2023 WG meeting.

@calvincestari
Copy link
Contributor Author

@twof, I think this captures the changes we spoke about for the proposal body.

I'm not sure what to do for the decision log though; I want to leave the decision log items there to note what was decided in the past but leaving them there could detract from our goal of going back to basics.. Any ideas?

@twof
Copy link
Contributor

twof commented Jul 31, 2023

@calvincestari I would say keep the decision log append-only, adding the most recent decisions to the top, and date the new ones. It's likely we return to some of the features we're scrapping, so having a summary of the decisions we made last time will help with future discussions.

@benjie
Copy link
Member

benjie commented Jul 31, 2023

Mark this as ready and ping me when it's ready for merge. RFCs get merged easily, they don't need much review process.

Copy link
Contributor

@aprilrd aprilrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me too.

@twof, I think this captures the changes we spoke about for the proposal body.

I'm not sure what to do for the decision log though; I want to leave the decision log items there to note what was decided in the past but leaving them there could detract from our goal of going back to basics.. Any ideas?

Talking about a decision log, would you like to add a new decision? Something akin to:

! as the only designator in the RFC

CCN WG decided to simplify the RFC at the 2023-07-26 meeting for the sake of progress. This reverses the "? as a counterpart to the !" decision.

The increased scope of the RFC with the nullability designator ? has stalled the RFC for more than two years (the initial RFC from April 2021).

One of the thorny decision points we encountered was around the proposed behaviors of the nullability designator ?. Regardless of the chosen path, it had unintuitive semantics (see graphql/nullability-wg#2), which require other RFCs, such as fragment boundaries, or new ideas like inline errors.

Even though we recognize the value of having a counterpart to !, We made a tradeoff decision to provide value to the community sooner than later.

@calvincestari
Copy link
Contributor Author

Talking about a decision log, would you like to add a new decision?

@aprilrd - yes I'll be adding a new entry to the decision log. Thanks for the great suggestion!

@calvincestari calvincestari marked this pull request as ready for review July 31, 2023 17:26
@calvincestari
Copy link
Contributor Author

@benjie, this should now be ready for merging - thanks.

@benjie benjie merged commit 64c7f2e into graphql:main Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants