Make 'Field Selections' header stable #773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
benjie
force-pushed
the
field-selections
branch
from
693d60b to
9687dd3
Compare
benjie
force-pushed
the
field-selections
branch
from
9687dd3 to
512e0bf
Compare
IvanGoncharov
added
the
✏️ Editorial
|
Thanks @benjie 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #733, @leebyron suggested renaming this header to simply 'Field Selections' with the line below it. I assume this is to increase the stability of this header such that permalinks to it will be stable.
It makes sense to me to introduce this change as early as possible, so I've separated it out into this PR.
Note: this also fixes a gramatical issue, it should read
on Objects, Interfaces, and Unionsoron Object, Interface and Union Types; the mixed plural currently seems incorrect.